Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py to inclusively handle maximum version #2001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

branisk
Copy link

@branisk branisk commented Oct 28, 2023

Updated to accept up to version 3.2.0 (the current latest version), instead of accepting only versions less than 3.2.0.

Motivation

Issue #2000, unable to install mmocr using the standard instructions on a fresh environment led me to experience this compatibility issue.

Modification

Changed compatibility in mmocr init.py file to be inclusive of the maximum version (3.2.0), instead of including strictly less than the maximum version.

Updated to accept up to version 3.2.0 (the current latest version), instead of accepting only versions less than 3.2.0.
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@taziksh taziksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. had the same issue locally, worked with this change

@lde2015
Copy link

lde2015 commented Nov 14, 2023

Hi,
Can you please tell us when the problem will be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants